[Benchmark] fail test if model artifact does not exist - #8482
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8482
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f2b250e with merge base a0924f7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
yangw-dev
commented
Feb 13, 2025
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
yangw-dev
force-pushed
the
failedTestSpec
branch
from
February 13, 2025 22:13
31d500b to
5ff1e8f
Compare
yangw-dev
had a problem deploying
to
upload-benchmark-results
February 13, 2025 22:14 — with 
GitHub Actions
Failure
yangw-dev
force-pushed
the
failedTestSpec
branch
from
February 13, 2025 23:08
09fa7a9 to
a0d81f8
Compare
yangw-dev
had a problem deploying
to
upload-benchmark-results
February 13, 2025 23:58 — with
GitHub Actions
Failure
yangw-dev
marked this pull request as ready for review
February 14, 2025 00:10
huydhn
approved these changes
Feb 14, 2025
huydhn
left a comment
Contributor
There was a problem hiding this comment.
LGTM! As the build is broken atm with a fix #8474 (review) coming. So, let's wait for fix to land and do a rebase
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 14, 2025 00:45 — with
GitHub Actions
Inactive
yangw-dev
force-pushed
the
failedTestSpec
branch
from
February 14, 2025 20:25
70af338 to
102a0dc
Compare
yangw-dev
had a problem deploying
to
upload-benchmark-results
February 14, 2025 21:04 — with
GitHub Actions
Failure
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 14, 2025 21:42 — with
GitHub Actions
Inactive
yangw-dev
force-pushed
the
failedTestSpec
branch
from
February 18, 2025 22:53
102a0dc to
9e38e39
Compare
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 18, 2025 23:35 — with
GitHub Actions
Inactive
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 19, 2025 00:08 — with
GitHub Actions
Inactive
yangw-dev
force-pushed
the
failedTestSpec
branch
from
February 28, 2025 02:31
9e38e39 to
f2b250e
Compare
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 28, 2025 03:20 — with
GitHub Actions
Inactive
yangw-dev
temporarily deployed
to
upload-benchmark-results
February 28, 2025 07:01 — with
GitHub Actions
Inactive
yangw-dev
added a commit
that referenced
this pull request
Mar 6, 2025
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8125
Fails the benchmark-on-device job the job at verification step if artifacts don't exist.
Verily Test Spectto download the test-specDetails
move prepare-test-specs under export-models, add dependency on export-models job.
The prepare-test-specs will fail to generate test-spec if no model exists in s3, this can cause the benchmark-on-device job fail at step
verily test-specothers
the failure in this pr seems like not related to this pr
see test pr: #8484
just added echo, it still fails