Adding permissions manager#34
Merged
amaury901130 merged 3 commits intomasterfrom Aug 13, 2020
Merged
Conversation
Closed
mato2593
approved these changes
Aug 13, 2020
Contributor
mato2593
left a comment
There was a problem hiding this comment.
I like this idea of encapsulating permissions logic in one place, good job!
Comment on lines
+25
to
+26
| permissionListener = listener | ||
| requestPermission(arrayOf(permission)) |
Contributor
There was a problem hiding this comment.
I'd call checkPermissions(arrayOf(permission), listener) to keep the logic in one place.
| return | ||
| } | ||
|
|
||
| val permissionDenied = mutableListOf<String>() |
Contributor
There was a problem hiding this comment.
I'd call this deniedPermissions.
| } | ||
| } | ||
|
|
||
| val granted = permissionDenied.size == 0 |
Contributor
There was a problem hiding this comment.
Can you use isEmpty or something equivalent instead?
Comment on lines
+57
to
+62
| for (s in permissionDenied) { | ||
| if (!ActivityCompat.shouldShowRequestPermissionRationale(this, s)) { | ||
| listener.foreverDenied() | ||
| return | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| for (s in permissionDenied) { | |
| if (!ActivityCompat.shouldShowRequestPermissionRationale(this, s)) { | |
| listener.foreverDenied() | |
| return | |
| } | |
| } | |
| for (deniedPermission in deniedPermission) { | |
| if (!ActivityCompat.shouldShowRequestPermissionRationale(this, deniedPermission)) { | |
| listener.foreverDenied() | |
| return | |
| } | |
| } |
Comment on lines
+24
to
+27
| fun checkPermission(permission: String, listener: PermissionResponse) { | ||
| permissionListener = listener | ||
| requestPermission(arrayOf(permission)) | ||
| } |
Contributor
There was a problem hiding this comment.
Same here as in the activity.
| return | ||
| } | ||
|
|
||
| val permissionDenied = mutableListOf<String>() |
Contributor
There was a problem hiding this comment.
Same here, deniedPermissions.
| when { | ||
| granted -> listener.granted() | ||
| else -> { | ||
| for (s in permissionDenied) { |
Contributor
There was a problem hiding this comment.
Same here, we should give the constant a more descriptive name than s. It should be called deniedPermission.
…ssionManager.kt Co-authored-by: Mathías Cabano <cabanomathias@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description