Skip to content

Custom image for scratchable area#4

Closed
ChathuraHettiarachchi wants to merge 1 commit into
sharish:masterfrom
ChathuraHettiarachchi:master
Closed

Custom image for scratchable area#4
ChathuraHettiarachchi wants to merge 1 commit into
sharish:masterfrom
ChathuraHettiarachchi:master

Conversation

@ChathuraHettiarachchi
Copy link
Copy Markdown

Added attributes to change scratchable area. User only need to add
app:customScrach on xml to change overlay image. user can pass drawable.

Added attributes to change scratchable area. User only need to add
app:customScrach on xml to change overlay image. user can pass drawable.
@burakkoray
Copy link
Copy Markdown

Hi
Have you merged this enhancement ?
If you have any chance to do that please could you make it ?

@sharish
Copy link
Copy Markdown
Owner

sharish commented Oct 25, 2016

The ScratchView was designed with the idea of real scratch card in software world. Having the customised version of scratch pattern image though techinically a very good enhancement, I'm afraid to merge as it takes away feel of scratch card to "erasing an image placed on another". Moreover I would like to keep this repo much simpler without customisations. This pull request will not be merged for the above reasons. If you are still interested with the customisation, you can refer the forked repo - https://github.com/ChathuraHettiarachchi/ScratchView.

Thanks,
Harish

@sharish sharish closed this Oct 25, 2016
@burakkoray
Copy link
Copy Markdown

Thanks Harish for this great project . I forked and used this project
Many thanks...

@atulac
Copy link
Copy Markdown

atulac commented Mar 1, 2019

The ScratchView was designed with the idea of real scratch card in software world. Having the customised version of scratch pattern image though techinically a very good enhancement, I'm afraid to merge as it takes away feel of scratch card to "erasing an image placed on another". Moreover I would like to keep this repo much simpler without customisations. This pull request will not be merged for the above reasons. If you are still interested with the customisation, you can refer the forked repo - https://github.com/ChathuraHettiarachchi/ScratchView.

Thanks,
Harish

Just an opinion and a request:
With Google Pay and PhonePe kind of giants building scratch cards with a custom interface, I think it becomes imperative to understand it's need. Repo deserves an upgrade. It's your call anyways.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants