This repository was archived by the owner on Oct 26, 2022. It is now read-only.
Integration testing against Ruby 2.6#42
Merged
Merged
Conversation
Turns out Travis detects a lot of this stuff for us and these bundle commands were being run AFTER travis already installed bundler and installed project gems
Contributor
Author
ghost
approved these changes
Feb 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We're on the heels of Ruby 2.3 dropping out of support and ruby 2.6 is seeing serious production usage. It's time we start testing against 2.6.
Solution
There a few things here:
before_installin travis config...turns out, travis is doing more autodetection than I knew and bundler and the gem bundle were being installed/created before these scripts even ran.Notes
I also removed a premature version bump in GraphQL::Cache::VERSION
Resolves #41