Feature/download progress by DSilence · Pull Request #209 · werwolfby/monitorrent

DSilence · 2017-04-02T19:03:30Z

Also added logs

werwolfby

Please split this changes from #203 to #210 only

werwolfby · 2017-04-02T19:05:33Z

        if exc_value is not None:
            formatted_exception = u''.join(traceback.format_exception(exc_type, exc_value, exc_tb))
-            failed_message = u'{0}<br/><pre>{1}</pre>'\
+            failed_message = u'{0}<br/><pre>{1}</pre>' \


Are you sure about space? :)

werwolfby · 2017-04-02T19:06:51Z

            engine.execute(ids)
        except:
            caught_exception = sys.exc_info()[0]
+            log.error("An error has occurred during execute", exception=str(caught_exception))


This doesn't provide stacktrace info, may be log.error already support it?

Well, it doesn't, as sys.exc_info()[0] returns exception type only (ref to https://docs.python.org/2/library/sys.html#sys.exc_info)
Also, it's worth to mention, that structlog has it's own event and render for handling exceptions (take a look at http://structlog.readthedocs.io/en/stable/api.html#structlog.stdlib.BoundLogger.exception)

Btw, may I ask (as not that experienced python developer) - why sys.exec_info instead of traceback.print_exception ? It's not that safe to assign it to a local variable (from docs and SO discussions).

We store it for next usage, not for printing right now.
And from docs:

Process event and call logging.Logger.error() with the result, after setting exc_info to True.

That was what I'm asked for, thx

werwolfby · 2017-04-02T19:08:09Z

                                                        list(self.clients.values())[0] if len(self.clients) > 0 else None)

    def set_default(self, name):
+


werwolfby · 2017-04-02T19:13:25Z

+            if torrent_settings.download_dir is not None:
+                torrent_settings_dict['download_dir'] = torrent_settings.download_dir
+        client.add_torrent(base64.b64encode(torrent).decode('utf-8'), **torrent_settings_dict)
+        return True


I think we can remove such return True because right now if there are no exception, than it is ok :)

werwolfby · 2017-04-02T19:18:10Z


        torrent_hash = 'SomeRandomHashMockString'
- self.assertFalse(plugin.find_torrent(torrent_hash))
+ assert plugin.find_torrent(torrent_hash) is False


I didn't know it is supported syntax 👍

werwolfby · 2017-04-02T19:21:05Z

@@ -112,53 +103,40 @@ def add_torrent(self, torrent, torrent_settings):
        client = self.check_connection()
        if not client:
            return False


We should throw exception instead in check connection directly

# Conflicts: # monitorrent/plugins/clients/deluge.py # monitorrent/plugins/clients/qbittorrent.py # monitorrent/plugins/clients/transmission.py # monitorrent/plugins/clients/utorrent.py # monitorrent/rest/notifiers.py # tests/plugins/clients/test_qbittorrent.py # tests/plugins/clients/test_transmission_plugin.py # tests/plugins/clients/test_utorrent_plugin.py # tests/rest/test_api_clients.py # tests/rest/test_api_execute.py # tests/rest/test_api_notifiers.py

coveralls · 2017-04-30T17:05:42Z

Coverage decreased (-0.04%) to 99.914% when pulling ea228e6 on DSilence:feature/download_progress into a9de167 on werwolfby:develop.

codecov-io · 2017-05-01T16:25:45Z

Codecov Report

Merging #209 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop   #209    +/-   ##
=======================================
  Coverage      100%   100%            
=======================================
  Files           55     55            
  Lines         4468   4631   +163     
=======================================
+ Hits          4468   4631   +163

Impacted Files	Coverage Δ
monitorrent/plugins/trackers/tapochek.py	`100% <100%> (ø)`	⬆️
monitorrent/engine.py	`100% <100%> (ø)`	⬆️
monitorrent/rest/execute.py	`100% <100%> (ø)`	⬆️
monitorrent/plugins/clients/utorrent.py	`100% <100%> (ø)`	⬆️
monitorrent/rest/new_version.py	`100% <100%> (ø)`	⬆️
monitorrent/plugins/clients/transmission.py	`100% <100%> (ø)`	⬆️
monitorrent/plugins/clients/downloader.py	`100% <100%> (ø)`	⬆️
monitorrent/plugin_managers.py	`100% <100%> (ø)`	⬆️
monitorrent/rest/notifiers.py	`100% <100%> (ø)`	⬆️
monitorrent/plugins/clients/deluge.py	`100% <100%> (ø)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9de167...44d1f2c. Read the comment docs.

coveralls · 2017-05-01T16:29:58Z

Coverage decreased (-0.04%) to 99.914% when pulling b9c80e4 on DSilence:feature/download_progress into a9de167 on werwolfby:develop.

coveralls · 2017-05-01T16:29:58Z

Coverage decreased (-0.04%) to 99.914% when pulling b9c80e4 on DSilence:feature/download_progress into a9de167 on werwolfby:develop.

coveralls · 2017-05-01T16:46:03Z

Coverage increased (+0.002%) to 99.957% when pulling 741193d on DSilence:feature/download_progress into a9de167 on werwolfby:develop.

DSilence · 2017-05-01T17:22:30Z

Updated the pull request

coveralls · 2017-05-01T17:23:24Z

Coverage increased (+0.002%) to 99.957% when pulling 44d1f2c on DSilence:feature/download_progress into a9de167 on werwolfby:develop.

Fixed the issues

DSilence added 8 commits March 11, 2017 20:42

feat(progress): added torrent download progress

e8e15c6

fix(plugins/clients/deluge): fixed deluge issues werwolfby#200

6924a11

Merge branch 'develop' into feature/download_progress

8560f6f

feat(plugins/clients): code comments changes

bb18b29

chore(logs): implemented some initial logging

3d3d95c

chore(logs): added some execute logs

ad2c904

feat(plugins/clients): added more info retrieved from clients.

50a8c78

chore(tests): restored 100% coverage

85b5d2a

DSilence added the in progress label Apr 2, 2017

fix(plugins): replaced enum package with more advanced one

5d11a8c

werwolfby self-requested a review April 2, 2017 19:25

werwolfby previously requested changes Apr 2, 2017

View reviewed changes

DSilence added 5 commits April 30, 2017 17:37

fix(test) postmerge fixes

89936ef

fix(plugins/clients/utorrent): incorrect import

c536159

fix(engine): some code comments fixes.

c740d68

feat(test): added tests for utorrent get_status method

ea228e6

fix(test): revetrted package change for enums, causing problems with p2

b9c80e4

chore(tests): restored coverage

741193d

chore(test): code quality improvements

44d1f2c

werwolfby force-pushed the develop branch 2 times, most recently from aa9da35 to 67a7ebc Compare April 6, 2023 07:37

werwolfby force-pushed the develop branch 2 times, most recently from ab4c80e to e42a621 Compare April 6, 2023 07:43

		list(self.clients.values())[0] if len(self.clients) > 0 else None)

		def set_default(self, name):

Conversation

DSilence commented Apr 2, 2017

Uh oh!

werwolfby left a comment

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

byg0n3 Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

werwolfby Apr 2, 2017

Choose a reason for hiding this comment

Uh oh!

coveralls commented Apr 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented May 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented May 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 1, 2017

Uh oh!

coveralls commented May 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DSilence commented May 1, 2017

Uh oh!

coveralls commented May 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

werwolfby Apr 2, 2017 •

edited

Loading

coveralls commented Apr 30, 2017 •

edited

Loading

codecov-io commented May 1, 2017 •

edited

Loading

coveralls commented May 1, 2017 •

edited

Loading

coveralls commented May 1, 2017 •

edited

Loading

coveralls commented May 1, 2017 •

edited

Loading