Add AuditLogs module#18
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
0a50405 to
f816f9e
Compare
blairworkos
left a comment
There was a problem hiding this comment.
Nice! I'm learning so much from this PR.
Should we add support for passing the idempotency key in the create method? I think we need to adjust the client logic to add this as a header when passed as a parameter.
| that the event is associated with. | ||
| - range_start (string) ISO-8601 value for start of the export range. | ||
| - range_end (string) ISO-8601 value for end of the export range. | ||
| - actions (list) List of actions to filter against. |
There was a problem hiding this comment.
Should this be noted as a "list of strings" specifically? I'm not sure how much this matters, because of dynamic typing.
There was a problem hiding this comment.
yea I wasn't sure if there was a specific way to define the type in the list or if I could just put (list of strings)
| is_map_key(params, :range_end) do | ||
| post( | ||
| "/audit_logs/exports", | ||
| %{ |
There was a problem hiding this comment.
Would we want to use the process_params method here, like in create organizations?
There was a problem hiding this comment.
makes sense!
| """ | ||
|
|
||
| def get_export(id, opts \\ []) | ||
| def get_export(id, opts) when is_binary(id) do |
There was a problem hiding this comment.
TIL: I was so confused that is_binary was being used to check that the ID is a string, but then a found this: https://www.educative.io/answers/what-is-isbinary-in-elixir 🎉
There was a problem hiding this comment.
Github Copilot taught me this 🤣
There was a problem hiding this comment.
The robots have taken over! lol
No description provided.