Add groups to directory sync user struct#59
Merged
Conversation
Why: * When pulling the directory sync user data from the WorkOS API, the list of groups is not included in the user schema, even though it is included in the WorkOS API response. This commit adds the list of groups associated with a given user to the directory sync user schema.
fix: Add groups to users
|
Hi @marktran - would it be possible to get this upstreamed? We've been using this patch in production at firezone/firezone for about 2 months now with no issues. |
PaulAsjes
approved these changes
Aug 29, 2024
Member
|
Thanks for the nudge, @jamilbk. We'll get this merged and publish a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In looking through the WorkOS API docs, I noticed the response for directory sync users included groups nested within the user data. When attempting to use the workos-elixir package I ran in to an issue where I needed the group information for a user, however it wasn't part of the user struct.
This PR adds the groups info to the directory sync user struct.
Thank you for considering this PR and please let me know if I need to change/add anything.