Everyone complains that a certain developer's code is not up to standard and when they have to take over his project the lack of code quality is really slowing them down.

I look at code, agree it is poor quality and put together a learning plan for said developer.

Also look at who approved every pull request which allowed bad code into our codebase. Same developers as those complaining it's no good. You had your chance to stop it!

Have you looked at microshits C coding style? Where the comment describing what the function does is put between the parameter head thingie and the body?

@b3b3 are u serious?? Who does that?

@b3b3 What the hell?
Link, please. I want to print out their style guide and burn it.

@Root while you're at it, could you also print a copy for me and burn that too?

@shiv7071007 @Root It was some windows driver examples. https://code.msdn.microsoft.com/win... this is what I was able to find. Not sure if it's the right one but I'm not at home rn so I cannot verify. The hard disk driver I think.

@fzammetti I get the point you're making and there's definitely an element of pressure from external sources sometime. But that's no excuse for willingly allowing low quality work into our products.

Pull requests are an opportunity for a discussion and to sanity check with college, not just a gateway to pass otherwise there is no point doing then.

In this specific case, pressure was not an issue, it's just the developer doesn't understand some of the fundamentals and others have just ignored the problem until it affects them.

@fzammetti and of expect better feedback than "this is shit". I expect constructive feedback and helpful discussions.