Learn More
Resend Email
3
Techno-Wizard
7y

I simplified 7 functions down to a blob because it was truly unreadable and fragmented. As I did it, I thought there was no way I did it right. This can't be the logic. Nope. It is.

Yeah, the formatting could be better. End of the shift so that's a tomorrow thing.

rant
Favorite
Ranter
Comments
  • 1
    7y
    I'd just go for

    ```
    .if DB[ODWR_CLAIM_ONLY.DATE3] == 1/1/1900
    . return DB[ODWR_CLAIM_ONLY.DATE2]
    .else
    . return formatDate(getOldDateValue())
    ```

    by splitting this function doing 2 things into 2 functions doing 1 thing each.

    /SRP
  • 1
    7y
    you can shorten the "if 9/1/2002" and the following elseif to one "if 9/1/2002 < old_date_value <= 9/18/2011:"
  • 0
    7y
    My first thought was "oh shit, what language is this atrocity" and then I realized it's Python. Didn't realize it can get this ugly.
  • 1
    7y
    @gronostaj its not python.
  • 1
    7y
    @stop Right, those dates really don't look like valid Python ;) What is it then?
  • 2
    7y
    @gronostaj it's pythonic pseudo code for management types who can't understand python shortcuts
  • 0
    7y
    after inspecting the database, that date constant doesn't exist.

    F me. Now I have to clean up that mess too
  • 0
    7y
    Btw, the last else is irrelevant, you can just return the function
  • 1
    7y
    Y'all suggesting code improvements...I just tilted my phone to remove the glare
  • 0
    7y
    @zpeters that was the best I could do. All angles had glare
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment