Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
“Fix that shit. This will cause performance issues” is kind of a terrible code review comment.
Does the author of the code you’re reviewing understand why it may cause performance issues? Probably not, or they would have coded it differently. The tone of the review comment is confrontational and judgmental, which would also make the original author defensive and less likely to ask for clarification.
Just sayin’. -
@AmyShackles That was a rephrased comment, with some salt added from myself. The original comment was worded correctly.
-
@netikras MC Donalds janitors are better than this...
Found this in our codebase, apparently one of my co-workers had written this
When McDonald's janitors are writing code...
Dev1: *creates a MR*
Code: for each HTTP request do
// stuff
Executors.newFixedThreadPool(validators.size()); // effectively meaning will start 7 new threads for each incoming request
// other stuff
Dev2: ^^ ??? Fix that shit. This will cause performance problems.
Dev1: *updates the code*
Code:
// stuff
int THREAD_NUMBER = 10;
Executors.newFixedThreadPool(THREAD_NUMBER);
// other stuff
Everyone: 🤦♂️🤦♂️🤦♂️🤦♂️
Can I BE facepalming any more?
rant
🤦♂️
wtf
facepalm
code monkeys
smh