Learn More
Resend Email
116
Worst code review experience?
Week 72 Group Rant
ashokramcse
9y

I was suppose to review this code.

if (null != value) {
return value;
} else {
return null;
}

rant

java

null

wk72

if else
Favorite
Ranter
Comments
  • 13
    9y
    That's deep. Or shallow.
  • 8
    9y
    I mean, it kind of makes sense. It shows, that getting null here is an expected behavior, but it's a special case that needs to be handled separately.

    Expressing intent is much more important than brevity.
  • 7
    9y
    (value == null) ? return null : return value;

    There you go.
  • 25
    9y
    @beggarboy how about return value; ? #smh
  • 5
    9y
    Are the lines all aligned because that's how the programmer did it, or because you did it because that's easier than aligning them on the phone for ranting?
  • 3
    9y
    @QueenMorgana hope the latter
  • 5
    9y
    @olezhka That's why I'm asking. I really hope it's the latter
  • 12
    9y
    I can't believe there's even a discussion about this.
  • 7
    9y
    @sSam I can't belive i read the discussion till the end.
  • 1
    9y
    Eww
  • 4
    9y
    I understand that this is a silly block of code that could've just been "return value;", but the "if (null != value)" just makes so irrationally angry. Make it "if (value == null)".
  • 3
    9y
    @beggarboy if you want to use the ternary operator in a return statement, at least do it properly:
    return value == null ? null : value

    But @olezhka is right, just write return value;
  • 1
    9y
    Wtf, I’m so confused
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment