Skip to content

[pull] master from iluwatar:master #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 26 commits into from
Nov 6, 2022
Merged

[pull] master from iluwatar:master #26

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ae64433
dependencies: update spring-boot-dependencies 2.0.9 to 2.7.5 (#2156)
robertvolkmann Oct 30, 2022
9dc91d8
docs: add robertvolkmann as a contributor for code (#2292)
allcontributors[bot] Oct 30, 2022
2b29479
Fix #1929: Suppress logging hibernate internals (#2158)
robertvolkmann Oct 30, 2022
4a6d652
docs: Updated documentation on comments on DefaultCircuitBreaker args…
bipin-k Oct 30, 2022
5afc32c
docs: add bipin-k as a contributor for doc (#2293)
allcontributors[bot] Oct 30, 2022
4cd8149
refactor: remove code smell java:S5786 (#2159)
robertvolkmann Oct 30, 2022
13cb2e8
docs: Data mapper1762 (#2165)
KyleSong30 Oct 30, 2022
cd736d7
docs: add KyleSong30 as a contributor for doc (#2294)
allcontributors[bot] Oct 30, 2022
adb0e25
refactor: Fix for maven warnings (#2157)
mohanaraosv Oct 30, 2022
badb828
docs: add robertvolkmann as a contributor for review (#2295)
allcontributors[bot] Oct 30, 2022
6660330
docs: Add Explanation for Data-Bus Design Pattern #590 (#2170)
DanielKim129 Oct 30, 2022
2dd1b55
docs: add u7281975 as a contributor for doc (#2296)
allcontributors[bot] Oct 30, 2022
12ce824
fix: Fix the CI build
iseppala Oct 30, 2022
e063bd1
translation: Closes iluwatar#2160 Translate template-method pattern r…
seongkyu-lim Oct 30, 2022
d9b4965
translation: Closes iluwatar#2161 Translate template-method pattern r…
seongkyu-lim Oct 30, 2022
cfeee23
translation: Closes iluwatar#2162 Translate template-method pattern r…
seongkyu-lim Oct 30, 2022
925996f
refactoring: Sonar issue fix for duplicate string (#2175)
harshalkhachane Nov 5, 2022
c8fa1a5
docs: add harshalkhachane as a contributor for code (#2312)
allcontributors[bot] Nov 5, 2022
6f21b10
refactoring: Sonar CRITICAL issue fixes (#2176)
harshalkhachane Nov 5, 2022
3605f8f
docs: Adding explanation for Producer-Consumer Design Pattern (#2179)
ManviGoel26 Nov 5, 2022
20ebbe0
docs: Replace profile url (#2183)
frascu Nov 5, 2022
3fde35a
refactoring: Adding lombok to MVC pattern (#2188)
burno1 Nov 5, 2022
cbb1eed
translation: remove unnecessary infor (#2192)
m-inh Nov 5, 2022
df52e1f
translation: Closes #2124 Translate the adapter readme to Spanish (#2…
aitorfi Nov 5, 2022
c9fc123
fix: Formatting of the main pom.xml
iseppala Nov 6, 2022
e955472
docs: add ec-026 as a contributor for translation (#2315)
allcontributors[bot] Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Fix for maven warnings (iluwatar#2157) 
* fix for maven warnings

* Removed unwanted dependency and htmlunit upgraded to latest

Co-authored-by: Mohana Rao S V <mohana.rao.s.v@tietoevry.com>
  • Loading branch information
@mohanaraosv @mohanraosv
mohanaraosv and mohanraosv authored Oct 30, 2022
commit adb0e25c2fa98c5e89b0bf056b31dfce4750d905
4 changes: 0 additions & 4 deletions metadata-mapping/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
<groupId>org.hibernate</groupId>
<artifactId>hibernate-core</artifactId>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
</dependency>
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion page-object/test-automation/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<dependencies>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
6 changes: 3 additions & 3 deletions page-object/test-automation/src/main/java/com/iluwatar/pageobject/AlbumListPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ public boolean isAt() {
*/
public AlbumPage selectAlbum(String albumTitle) {
// uses XPath to find list of html anchor tags with the class album in it
var albumLinks = (List<HtmlAnchor>) page.getByXPath("//tr[@class='album']//a");
var albumLinks = (List<Object>) page.getByXPath("//tr[@class='album']//a");
for (var anchor : albumLinks) {
if (anchor.getTextContent().equals(albumTitle)) {
if (((HtmlAnchor) anchor).getTextContent().equals(albumTitle)) {
try {
anchor.click();
((HtmlAnchor) anchor).click();
return new AlbumPage(webClient);
} catch (IOException e) {
LOGGER.error("An error occured on selectAlbum", e);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<camel.version>2.25.1</camel.version>
<guava.version>19.0</guava.version>
<mockito.version>3.5.6</mockito.version>
<htmlunit.version>2.22</htmlunit.version>
<htmlunit.version>2.66.0</htmlunit.version>
<guice.version>4.0</guice.version>
<mongo-java-driver.version>3.12.8</mongo-java-driver.version>
<aws-lambda-core.version>1.1.0</aws-lambda-core.version>
Expand Down