[pull] master from iluwatar:master

.all-contributorsrc

@@ -1600,7 +1600,7 @@
       "login": "frascu",
       "name": "Francesco Scuccimarri",
       "avatar_url": "https://avatars.githubusercontent.com/u/7107651?v=4",
-      "profile": "http://scuccimarri.it",
+      "profile": "https://github.com/frascu",
       "contributions": [
         "code"
       ]
@@ -2079,6 +2079,62 @@
       "contributions": [
         "translation"
       ]
+    },
+    {
+      "login": "robertvolkmann",
+      "name": "Robert Volkmann",
+      "avatar_url": "https://avatars.githubusercontent.com/u/20912167?v=4",
+      "profile": "https://github.com/robertvolkmann",
+      "contributions": [
+        "code",
+        "review"
+      ]
+    },
+    {
+      "login": "bipin-k",
+      "name": "Bipin Kumar Chaurasia",
+      "avatar_url": "https://avatars.githubusercontent.com/u/21119358?v=4",
+      "profile": "https://github.com/bipin-k",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "KyleSong30",
+      "name": "KyleSong30",
+      "avatar_url": "https://avatars.githubusercontent.com/u/100892032?v=4",
+      "profile": "https://github.com/KyleSong30",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "u7281975",
+      "name": "u7281975",
+      "avatar_url": "https://avatars.githubusercontent.com/u/111095623?v=4",
+      "profile": "https://github.com/u7281975",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "harshalkhachane",
+      "name": "harshalkhachane",
+      "avatar_url": "https://avatars.githubusercontent.com/u/92866584?v=4",
+      "profile": "https://github.com/harshalkhachane",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "ec-026",
+      "name": "Tejas Singh",
+      "avatar_url": "https://avatars.githubusercontent.com/u/95495584?v=4",
+      "profile": "https://github.com/ec-026",
+      "contributions": [
+        "doc",
+        "translation"
+      ]
     }
   ],
   "contributorsPerLine": 7,

README.md

@@ -10,7 +10,7 @@
 [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=iluwatar_java-design-patterns&metric=coverage)](https://sonarcloud.io/dashboard?id=iluwatar_java-design-patterns)
 [![Join the chat at https://gitter.im/iluwatar/java-design-patterns](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/iluwatar/java-design-patterns?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[![All Contributors](https://img.shields.io/badge/all_contributors-228-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-233-orange.svg?style=flat-square)](#contributors-)
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 <br/>
@@ -368,6 +368,14 @@ This project is licensed under the terms of the MIT license.
       <td align="center"><a href="https://github.com/steph88ss"><img src="https://avatars.githubusercontent.com/u/111041594?v=4?s=100" width="100px;" alt="steph88ss"/><br /><sub><b>steph88ss</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=steph88ss" title="Documentation">📖</a></td>
       <td align="center"><a href="http://yujanranjitkar.com.np"><img src="https://avatars.githubusercontent.com/u/63731234?v=4?s=100" width="100px;" alt="Yujan Ranjitkar"/><br /><sub><b>Yujan Ranjitkar</b></sub></a><br /><a href="#translation-0xYujan" title="Translation">🌍</a></td>
       <td align="center"><a href="https://github.com/yusha-g"><img src="https://avatars.githubusercontent.com/u/110189579?v=4?s=100" width="100px;" alt="yusha-g"/><br /><sub><b>yusha-g</b></sub></a><br /><a href="#translation-yusha-g" title="Translation">🌍</a></td>
+      <td align="center"><a href="https://github.com/robertvolkmann"><img src="https://avatars.githubusercontent.com/u/20912167?v=4?s=100" width="100px;" alt="Robert Volkmann"/><br /><sub><b>Robert Volkmann</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=robertvolkmann" title="Code">💻</a> <a href="https://github.com/iluwatar/java-design-patterns/pulls?q=is%3Apr+reviewed-by%3Arobertvolkmann" title="Reviewed Pull Requests">👀</a></td>
+      <td align="center"><a href="https://github.com/bipin-k"><img src="https://avatars.githubusercontent.com/u/21119358?v=4?s=100" width="100px;" alt="Bipin Kumar Chaurasia"/><br /><sub><b>Bipin Kumar Chaurasia</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=bipin-k" title="Documentation">📖</a></td>
+      <td align="center"><a href="https://github.com/KyleSong30"><img src="https://avatars.githubusercontent.com/u/100892032?v=4?s=100" width="100px;" alt="KyleSong30"/><br /><sub><b>KyleSong30</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=KyleSong30" title="Documentation">📖</a></td>
+    </tr>
+    <tr>
+      <td align="center"><a href="https://github.com/u7281975"><img src="https://avatars.githubusercontent.com/u/111095623?v=4?s=100" width="100px;" alt="u7281975"/><br /><sub><b>u7281975</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=u7281975" title="Documentation">📖</a></td>
+      <td align="center"><a href="https://github.com/harshalkhachane"><img src="https://avatars.githubusercontent.com/u/92866584?v=4?s=100" width="100px;" alt="harshalkhachane"/><br /><sub><b>harshalkhachane</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=harshalkhachane" title="Code">💻</a></td>
+      <td align="center"><a href="https://github.com/ec-026"><img src="https://avatars.githubusercontent.com/u/95495584?v=4?s=100" width="100px;" alt="Tejas Singh"/><br /><sub><b>Tejas Singh</b></sub></a><br /><a href="https://github.com/iluwatar/java-design-patterns/commits?author=ec-026" title="Documentation">📖</a> <a href="#translation-ec-026" title="Translation">🌍</a></td>
     </tr>
   </tbody>
 </table>

acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitorTest.java

@@ -74,7 +74,7 @@ void testVisitForHayes() {
 
   @BeforeEach
   @AfterEach
- public void clearLoggers() {
+  void clearLoggers() {
     TestLoggerFactory.clear();
   }
 }

acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitorTest.java

@@ -44,7 +44,7 @@ class ConfigureForUnixVisitorTest {
 
   @BeforeEach
   @AfterEach
- public void clearLoggers() {
+  void clearLoggers() {
     TestLoggerFactory.clear();
   }
 

adapter/README.md

@@ -112,12 +112,12 @@ Use the Adapter pattern when
 Class and object adapters have different trade-offs. A class adapter
 
 *	Adapts Adaptee to Target by committing to a concrete Adaptee class. As a consequence, a class adapter won’t work when we want to adapt a class and all its subclasses.
-*	Let’s Adapter override some of Adaptee’s behavior since Adapter is a subclass of Adaptee.
+*	Lets Adapter override some of Adaptee’s behavior since Adapter is a subclass of Adaptee.
 *	Introduces only one object, and no additional pointer indirection is needed to get to the adaptee.
 
 An object adapter	
 
-*	Lets a single Adapter work with many Adaptees—that is, the Adaptee itself and all of its subclasses (if any). The Adapter can also add functionality to all Adaptees at once.
+*	Lets a single Adapter work with many Adaptees, that is, the Adaptee itself and all of its subclasses (if any). The Adapter can also add functionality to all Adaptees at once.
 *	Makes it harder to override Adaptee behavior. It will require subclassing Adaptee and making the Adapter refer to the subclass rather than the Adaptee itself.
 
 

adapter/src/test/java/com/iluwatar/adapter/AdapterPatternTest.java

@@ -48,7 +48,7 @@ class AdapterPatternTest {
    * This method runs before the test execution and sets the bean objects in the beans Map.
    */
   @BeforeEach
- public void setup() {
+  void setup() {
     beans = new HashMap<>();
 
     var fishingBoatAdapter = spy(new FishingBoatAdapter());

aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java

@@ -48,7 +48,7 @@ class AggregatorTest {
   private ProductInventoryClient inventoryClient;
 
   @BeforeEach
- public void setup() {
+  void setup() {
     MockitoAnnotations.openMocks(this);
   }
 

api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java

@@ -48,7 +48,7 @@ class ApiGatewayTest {
   private PriceClient priceClient;
 
   @BeforeEach
- public void setup() {
+  void setup() {
     MockitoAnnotations.openMocks(this);
   }
 

business-delegate/src/test/java/com/iluwatar/business/delegate/BusinessDelegateTest.java

@@ -49,7 +49,7 @@ class BusinessDelegateTest {
    * execution of every test.
    */
   @BeforeEach
- public void setup() {
+  void setup() {
     netflixService = spy(new NetflixService());
     youTubeService = spy(new YouTubeService());
 

caching/src/test/java/com/iluwatar/caching/CachingTest.java

@@ -39,7 +39,7 @@ class CachingTest {
    * Setup of application test includes: initializing DB connection and cache size/capacity.
    */
   @BeforeEach
- public void setUp() {
+  void setUp() {
     // VirtualDB (instead of MongoDB) was used in running the JUnit tests
     // to avoid Maven compilation errors. Set flag to true to run the
     // tests with MongoDB (provided that MongoDB is installed and socket

callback/src/test/java/com/iluwatar/callback/CallbackTest.java

@@ -34,7 +34,7 @@
  * <p>
  * Could be done with mock objects as well where the call method call is verified.
  */
-public class CallbackTest {
+class CallbackTest {
 
   private Integer callingCount = 0;
 

circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java

@@ -45,10 +45,10 @@ public class DefaultCircuitBreaker implements CircuitBreaker {
    * Constructor to create an instance of Circuit Breaker.
    *
    * @param timeout          Timeout for the API request. Not necessary for this simple example
-   * @param failureThreshold Number of failures we receive from the depended service before changing
-   *                         state to 'OPEN'
-   * @param retryTimePeriod  Time period after which a new request is made to remote service for
-   *                         status check.
+   * @param failureThreshold Number of failures we receive from the depended on service before
+   *                         changing state to 'OPEN'
+   * @param retryTimePeriod  Time, in nanoseconds, period after which a new request is made to
+   *                         remote service for status check.
    */
   DefaultCircuitBreaker(RemoteService serviceToCall, long timeout, int failureThreshold,
       long retryTimePeriod) {

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/AppTest.java

@@ -34,7 +34,7 @@
 /**
  * App Test showing usage of circuit breaker.
  */
-public class AppTest {
+class AppTest {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class);
 
@@ -60,7 +60,7 @@ public class AppTest {
    * and retry time period of 2 seconds.
    */
   @BeforeEach
- public void setupCircuitBreakers() {
+  void setupCircuitBreakers() {
     var delayedService = new DelayedRemoteService(System.nanoTime(), STARTUP_DELAY);
     //Set the circuit Breaker parameters
     delayedServiceCircuitBreaker = new DefaultCircuitBreaker(delayedService, 3000,
@@ -78,7 +78,7 @@ public void setupCircuitBreakers() {
   }
 
   @Test
- public void testFailure_OpenStateTransition() {
+  void testFailure_OpenStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -93,7 +93,7 @@ public void testFailure_OpenStateTransition() {
   }
 
   @Test
- public void testFailure_HalfOpenStateTransition() {
+  void testFailure_HalfOpenStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN
@@ -112,7 +112,7 @@ public void testFailure_HalfOpenStateTransition() {
   }
 
   @Test
- public void testRecovery_ClosedStateTransition() {
+  void testRecovery_ClosedStateTransition() {
     //Calling delayed service, which will be unhealthy till 4 seconds
     assertEquals("Delayed service is down", monitoringService.delayedServiceResponse());
     //As failure threshold is "1", the circuit breaker is changed to OPEN

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/DefaultCircuitBreakerTest.java

@@ -26,13 +26,12 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-import java.rmi.Remote;
 import org.junit.jupiter.api.Test;
 
 /**
  * Circuit Breaker test
  */
-public class DefaultCircuitBreakerTest {
+class DefaultCircuitBreakerTest {
 
   //long timeout, int failureThreshold, long retryTimePeriod
   @Test

circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/DelayedRemoteServiceTest.java

@@ -53,7 +53,7 @@ void testDefaultConstructor() throws RemoteServiceException {
    * @throws RemoteServiceException
    */
   @Test
- public void testParameterizedConstructor() throws RemoteServiceException {
+  void testParameterizedConstructor() throws RemoteServiceException {
       var obj = new DelayedRemoteService(System.nanoTime()-2000*1000*1000,1);
       assertEquals("Delayed service is working",obj.call());
   }

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/consumer/callcostprocessor/functions/UsageCostProcessorFunctionTest.java

@@ -58,7 +58,7 @@
  * Unit test for Function class.
  */
 @ExtendWith(MockitoExtension.class)
-public class UsageCostProcessorFunctionTest {
+class UsageCostProcessorFunctionTest {
 
     @Mock
     MessageHandlerUtility<UsageDetail> mockMessageHandlerUtilityForUsageADetail;
@@ -74,7 +74,7 @@ public class UsageCostProcessorFunctionTest {
     UsageCostProcessorFunction usageCostProcessorFunction;
 
     @BeforeEach
- public void setUp() {
+    void setUp() {
         var messageBodyUsageDetail = new MessageBody<UsageDetail>();
         var usageDetailsList = new ArrayList<UsageDetail>();
 
@@ -122,7 +122,7 @@ public void setUp() {
      * Unit test for HttpTriggerJava method.
      */
     @Test
- public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")
@@ -148,7 +148,7 @@ public HttpResponseMessage.Builder answer(InvocationOnMock invocation) {
     }
 
     @Test
- public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
         // Setup
         @SuppressWarnings("unchecked")
         final HttpRequestMessage<Optional<String>> req = mock(HttpRequestMessage.class);

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/producer/calldetails/functions/UsageDetailPublisherFunctionTest.java

@@ -52,7 +52,7 @@
  * Unit test for Function class.
  */
 @ExtendWith(MockitoExtension.class)
-public class UsageDetailPublisherFunctionTest {
+class UsageDetailPublisherFunctionTest {
     @Mock
     MessageHandlerUtility<UsageDetail> mockMessageHandlerUtility;
     @Mock
@@ -65,7 +65,7 @@ public class UsageDetailPublisherFunctionTest {
      * Unit test for HttpTriggerJava method.
      */
     @Test
- public void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithSubscriptionValidationEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")
@@ -91,7 +91,7 @@ public HttpResponseMessage.Builder answer(InvocationOnMock invocation) {
     }
 
     @Test
- public void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
+    void shouldTriggerHttpAzureFunctionJavaWithUsageDetailEventType() throws Exception {
 
         // Setup
         @SuppressWarnings("unchecked")

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/utility/EventHandlerUtilityTest.java

@@ -40,7 +40,7 @@
 import org.mockito.junit.jupiter.MockitoExtension;
 
 @ExtendWith(MockitoExtension.class)
-public class EventHandlerUtilityTest {
+class EventHandlerUtilityTest {
 
     @Mock
     EventGridPublisherClient<BinaryData> mockCustomEventClient;
@@ -49,7 +49,7 @@ public class EventHandlerUtilityTest {
     EventHandlerUtility<Message<UsageDetail>> eventHandlerUtility;
 
     @BeforeEach
- public void setUp() {
+    void setUp() {
 
         System.setProperty("EventGridURL", "https://www.dummyEndpoint.com/api/events");
         System.setProperty("EventGridKey", "EventGridURL");

cloud-claim-check-pattern/call-usage-app/src/test/java/com/iluwatar/claimcheckpattern/utility/MessageHandlerUtilityTest.java

@@ -46,7 +46,7 @@
 import static org.mockito.Mockito.*;
 
 @ExtendWith(MockitoExtension.class)
-public class MessageHandlerUtilityTest {
+class MessageHandlerUtilityTest {
     @Mock
     private BlobClient mockBlobClient;
 
@@ -63,7 +63,7 @@ public class MessageHandlerUtilityTest {
     private MessageReference messageReference;
 
     @BeforeEach
- public void setUp() {
+    void setUp() {
         System.setProperty("BlobStorageConnectionString", "https://www.dummyEndpoint.com/api/blobs");
 
         var messageBody = new MessageBody<UsageDetail>();