Tests: avoid recompiling libgala for each test#2833
Open
Conversation
69706c8 to
a761b67
Compare
a761b67 to
ac4fe82
Compare
leolost2605
requested changes
Apr 26, 2026
Member
leolost2605
left a comment
There was a problem hiding this comment.
Makes sense to me but I think we should use a separate new library so that enabling tests doesn't change anything about the actual one. Also the #if TESTS arent really nice, is there a way to do it without introducing a lot of these conditions? Maybe have a macro that evaluates to private or public? Does vala support that?
Member
|
Just a quick google didn't investigate further but maybe --internal-vapi and friends might work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse libgala library instead of compiling a test + libgala into every test executable.
Because of this change I introduced a TESTS preprocessor variable to expose needed internal parts of the library to the tests.
This should significantly speed up compilation for large numbers of tests.