Skip to content

make FastPFor easier to use as submodule#123

Merged
lemire merged 3 commits intofast-pack:masterfrom
clapdb:master
Jan 21, 2025
Merged

make FastPFor easier to use as submodule#123
lemire merged 3 commits intofast-pack:masterfrom
clapdb:master

Conversation

@deafwolf
Copy link
Copy Markdown
Contributor

@deafwolf deafwolf commented Jan 21, 2025

fixes some cmake error and compile warning

  • ${CMAKE_MODULE_PATH}/simde.cmake may cause simde not found if use it as module
  • the size_t i shadow the variable i out of the loop
  • set CXX_FLAG and C_FLAG to avoid error when cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo

@lemire
Copy link
Copy Markdown
Member

lemire commented Jan 21, 2025

set CXX_FLAG and C_FLAG to avoid error when cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo

Everything looks fine, but this part I do not understand.

If you want a Release build, why don't you type cmake -DCMAKE_BUILD_TYPE=Release instead?

@lemire
Copy link
Copy Markdown
Member

lemire commented Jan 21, 2025

I am going to merge, but delete the set RelWithDebInfo flags as release part. If you need it, please issue a PR with an explanation.

@lemire lemire merged commit e0696b4 into fast-pack:master Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants