Skip to content

make FastPFor easier to use as submodule #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 3 commits into from
Jan 21, 2025
+10 −6
Merged

make FastPFor easier to use as submodule #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bc11f9
include simde as module instead of file
deafwolf Aug 16, 2024
38441b7
fix shadow variable
deafwolf Aug 16, 2024
fdc6f88
support RelWithDebInfo
deafwolf Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ if( SUPPORT_SSE42 )
MESSAGE( STATUS "SSE 4.2 support detected" )
else()
if (SUPPORT_NEON)
include("${CMAKE_MODULE_PATH}/simde.cmake")
include(simde)
MESSAGE(STATUS "USING SIMDE FOR SIMD OPERATIONS")
else ()
MESSAGE(STATUS "SIMDE and SSE 4.2 support not detected")
Expand Down Expand Up @@ -107,6 +107,10 @@ else ()
message(FATAL_ERROR "Please, use GCC, Clang, or the Intel compiler!")
endif()

# set RelWithDebInfo flags as release
set (CMAKE_CXX_FLAGS_RELWITHDEBINFO ${CMAKE_CXX_FLAGS_RELEASE})
set (CMAKE_C_FLAGS_RELWITHDEBINFO ${CMAKE_C_FLAGS_RELEASE})

MESSAGE( STATUS "CMAKE_CXX_FLAGS_DEBUG: " ${CMAKE_CXX_FLAGS_DEBUG} )
MESSAGE( STATUS "CMAKE_CXX_FLAGS_RELEASE: " ${CMAKE_CXX_FLAGS_RELEASE} )
MESSAGE( STATUS "CMAKE_C_FLAGS_DEBUG: " ${CMAKE_C_FLAGS_DEBUG} )
Expand Down
10 changes: 5 additions & 5 deletions headers/deltautil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,11 +493,11 @@ class Delta {
<< recoveredsize << std::endl;
throw std::logic_error("arrays don't have same size: bug.");
}
for (size_t i = 0; i < datas[k].size(); i++) {
if (datas[k][i] != recov[i]) {
std::cout << "difference at index " << i << ":" << std::endl;
std::cout << " expected: " << datas[k][i] << std::endl;
std::cout << " actual: " << recov[i] << std::endl;
for (size_t j = 0; j < datas[k].size(); j++) {
if (datas[k][j] != recov[j]) {
std::cout << "difference at index " << j << ":" << std::endl;
std::cout << " expected: " << datas[k][j] << std::endl;
std::cout << " actual: " << recov[j] << std::endl;
throw std::logic_error("we have a bug");
}
}
Expand Down